Skip to content

ENH: Use yaml anchors for pre-commit hooks additional dependencies #44177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 25, 2021
Merged

ENH: Use yaml anchors for pre-commit hooks additional dependencies #44177

merged 2 commits into from
Oct 25, 2021

Conversation

trallard
Copy link
Contributor

@trallard trallard commented Oct 25, 2021 •
edited
Loading

This PR adds:

  • use of yaml anchors for the flake8 and yesqa hooks
  • updates to scripts/sync_flake8_versions.py since now both yesqa and flake8 hooks have the same additional dependencies declared through a reusable anchor there is no need to check for sync between these two

PD. I am not sure this needs a whatsnew entry so I did not add it - unless y'all think there should be one

@MarcoGorelli MarcoGorelli self-requested a review October 25, 2021 11:58
MarcoGorelli
MarcoGorelli suggested changes Oct 25, 2021
View reviewed changes
Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, thanks for doing this

@jreback jreback added the Code Style Code style, linting, code_checks label Oct 25, 2021
@MarcoGorelli MarcoGorelli added this to the 1.4 milestone Oct 25, 2021
MarcoGorelli
MarcoGorelli approved these changes Oct 25, 2021
View reviewed changes
Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @trallard !

@MarcoGorelli MarcoGorelli merged commit d8440f1 into pandas-dev:master Oct 25, 2021
@trallard trallard deleted the trallard/pre-commit-anchors branch October 25, 2021 14:08
@trallard trallard mentioned this pull request Oct 26, 2021
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcoGorelli MarcoGorelli MarcoGorelli approved these changes

Assignees
No one assigned
Labels
Code Style Code style, linting, code_checks
Projects
None yet
Milestone
1.4
Development

Successfully merging this pull request may close these issues.

STYLE use yaml anchors in .pre-commit-config.yaml for flake8
3 participants
@trallard @MarcoGorelli @jreback